feat(db): add dateCreated and lastModified to Repo by sankalpsthakur · Pull Request #1656 · finos/git-proxy

sankalpsthakur · 2026-07-22T15:04:16Z

Summary

Add optional dateCreated / lastModified (ISO-8601) on the Repo model
Stamp both on create; bump lastModified on all user-role mutations (NeDB + Mongo)
No startup backfill — existing records without these fields stay as-is until a follow-up migration PR (per @andypols review in feat(db): add dateCreated and lastModified to Repo #1656)

Scope / issue linkage

This PR lands the persistence slice of #1486 (model fields + create/mutation timestamps). Remaining #1486 work is intentionally split out:

sortBy allowlist + UI sort options — blocked on / coordinated with feat: add server-side pagination to API endpoints #1464 server-side pagination
Existing-record backfill — follow-up PR introducing a versioned migration framework; first migration will derive Mongo dateCreated from $toDate("$_id") rather than defaulting to epoch (as suggested in review)

Unblocks Date Created / Date Modified sorting for newly created and recently mutated repos once #1464 lands.

Related: #1420 (broader admin sorting/pagination — #1464 covers the server half)

Test plan

npm test -- test/db (163 passed; 45 integration tests skipped because no external MongoDB was configured)
Create a repo and confirm both dates are set
Mutate canPush/canAuthorise → lastModified advances, dateCreated unchanged
Sort repo list by Date Created / Date Modified (once feat: add server-side pagination to API endpoints #1464 lands)

Fixes #1486

AI/LLM disclosure

AI coding tools (including Grok and/or Codex agent-assisted editing) were used to help draft or modify code and this PR description.
I reviewed the complete change, understand the reasoning, and ran the reported local tests before submitting.
This submission is original work of authorship under the project CLA / contributor terms; AI output was not pasted unreviewed.

netlify · 2026-07-22T15:04:22Z

✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name	Link
🔨 Latest commit	`fa86d42`
🔍 Latest deploy log	https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6a68c9577bdbe40008afd896

andypols

Thanks for the contribution — it will be really useful to see recently added repositories in the proxy.

I do have reservations about the migration approach. Running one-off backfills during application startup is difficult to track, retry, test, and roll back, and it will not scale well as more migrations are introduced.

I think the migration work should move to a separate PR that introduces a small, explicit migration framework with versioned migrations, tracking of completed migrations, proper error handling, and documented recovery or rollback behaviour. We can then add the backfill for these new fields as the first migration.

We should also use a more meaningful creation date for existing records rather than defaulting everything to 1970. For MongoDB records with a standard ObjectId, the creation timestamp can be derived from _id, for example:

await collection.updateMany(
  {
    $or: [
      { dateCreated: { $exists: false } },
      { lastModified: { $exists: false } },
    ],
  },
  [
    {
      $set: {
        dateCreated: {
          $ifNull: ["$dateCreated", { $toDate: "$_id" }],
        },
        lastModified: {
          $ifNull: [
            "$lastModified",
            { $ifNull: ["$dateCreated", { $toDate: "$_id" }] },
          ],
        },
      },
    },
  ],
);

Remove backfillRepoDates and startup hooks; existing-repo migration will follow in a separate PR with a versioned migration framework. Co-authored-by: Cursor <cursoragent@cursor.com>

linux-foundation-easycla · 2026-07-22T19:09:55Z

The committers listed above are authorized under a signed CLA.

✅ login: sankalpsthakur / name: Sankalp Thakur (22b634a, 6c10ce6, 78f78ea, e48258a)

Remove backfillRepoDates and startup hooks; existing-repo migration will follow in a separate PR with a versioned migration framework. Co-authored-by: Cursor <cursoragent@cursor.com>

Remove backfillRepoDates and startup hooks; existing-repo migration will follow in a separate PR with a versioned migration framework.

sankalpsthakur · 2026-07-22T19:10:25Z

Thanks @andypols — agreed on deferring migration to a dedicated PR.

Changes in 065fab5:

Removed backfillRepoDates from both Mongo and NeDB adaptors
Removed the startup backfill hooks in src/db/index.ts
Dropped the related unit tests

This PR now only adds dateCreated / lastModified on new repos and bumps lastModified on user-role mutations. I'll follow up separately with a versioned migration framework and use $toDate on _id for existing Mongo records as you suggested.

sankalpsthakur · 2026-07-22T23:47:55Z

The migration/backfill code remains removed as requested. I have now completed the two available behavior checks and updated the PR checklist:

npm test -- test/db: 163 passed; 45 external-Mongo integration tests skipped because no MongoDB service was configured.
A direct in-memory NeDB exercise created a real repo record, confirmed ISO-8601 dateCreated === lastModified, then ran add/remove mutations for both canPush and canAuthorise; each mutation advanced lastModified while preserving dateCreated.

Sorting remains explicitly deferred to #1464. Could you please re-review the narrowed persistence-only PR when convenient?

codecov · 2026-07-23T01:29:00Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.23%. Comparing base (9bc9c0d) to head (10f21a6).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1656      +/-   ##
==========================================
+ Coverage   85.97%   86.23%   +0.26%     
==========================================
  Files          87       87              
  Lines        8621     8646      +25     
  Branches     1492     1494       +2     
==========================================
+ Hits         7412     7456      +44     
+ Misses       1178     1160      -18     
+ Partials       31       30       -1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sankalpsthakur · 2026-07-23T11:49:39Z

@andypols Migration/backfill is out of this PR as requested — persistence-only now. Mind taking another look?

Remove backfillRepoDates and startup hooks; existing-repo migration will follow in a separate PR with a versioned migration framework.

sankalpsthakur · 2026-07-27T09:30:41Z

Thanks @andypols — agreed on all points.

This PR no longer runs any startup backfill. backfillRepoDates and the boot-time hooks are gone; we only stamp dateCreated / lastModified on create and bump lastModified on user-role mutations. Existing records without those fields stay unset for now.

Follow-up PR plan (as you suggested):

Introduce a small versioned migration framework (tracking, error handling, documented recovery/rollback)
Make the repo date backfill the first migration
For Mongo, derive missing dateCreated/lastModified from $toDate: "$_id" rather than defaulting to 1970

Happy to re-review when convenient — persistence-only scope is intentional here.

Remove backfillRepoDates and startup hooks; existing-repo migration will follow in a separate PR with a versioned migration framework.

sankalpsthakur · 2026-07-28T08:56:07Z

Rebased onto latest main — the earlier merge commit broke EasyCLA. All commits are mine again; test/db green (119 passed). @andypols ready when you are.

sankalpsthakur · 2026-07-28T09:07:47Z

/easycla

andypols · 2026-07-28T09:34:15Z

@sankalpsthakur there is an error due to a cursor co-author in the commit - can you please fix that as it is blocking the PR?

sankalpsthakur · 2026-07-28T10:01:19Z

Removed the Cursor co-author trailer (and dropped the empty EasyCLA retrigger commit). Should be clear now.

sankalpsthakur · 2026-07-28T10:07:29Z

@andypols Cursor co-author cleared and EasyCLA is green. Persistence-only as requested — mind another look?

Populate dates on create and bump lastModified on user-role mutations. Backfill missing fields on NeDB/Mongo startup so Date Created/Modified sorting in the repo list works for existing records. Fixes finos#1486.

Remove backfillRepoDates and startup hooks; existing-repo migration will follow in a separate PR with a versioned migration framework.

NeDB adaptor already bumps lastModified on all user-role mutations; extend finos#1486 date-field tests to assert removeUserCanAuthorise preserves dateCreated while advancing lastModified.

Record that existing-record backfill stays out of startup and belongs in a follow-up versioned migration using Mongo $toDate on _id.

sankalpsthakur requested a review from a team as a code owner July 22, 2026 15:04

sankalpsthakur changed the title ~~feat(db): add dateCreated and lastModified on repos~~ feat(db): add dateCreated and lastModified to Repo Jul 22, 2026

sankalpsthakur mentioned this pull request Jul 22, 2026

Add Date Modified and Date Created sorting for repositories #1486

Open

andypols requested changes Jul 22, 2026

View reviewed changes

sankalpsthakur force-pushed the prep/1486-repo-date-fields branch from e41612a to 1d4da08 Compare July 22, 2026 19:09

sankalpsthakur force-pushed the prep/1486-repo-date-fields branch from 1d4da08 to f74be7d Compare July 22, 2026 19:10

sankalpsthakur force-pushed the prep/1486-repo-date-fields branch from f74be7d to 065fab5 Compare July 22, 2026 19:10

sankalpsthakur force-pushed the prep/1486-repo-date-fields branch from fe8f6e3 to 10f21a6 Compare July 22, 2026 19:34

sankalpsthakur force-pushed the prep/1486-repo-date-fields branch from 10f21a6 to c2de1b8 Compare July 24, 2026 20:42

kriswest linked an issue Jul 27, 2026 that may be closed by this pull request

Add Date Modified and Date Created sorting for repositories #1486

Open

sankalpsthakur force-pushed the prep/1486-repo-date-fields branch from 54527af to e40fd09 Compare July 28, 2026 08:53

sankalpsthakur force-pushed the prep/1486-repo-date-fields branch 2 times, most recently from e1c60d1 to 78f78ea Compare July 28, 2026 10:01

sankalpsthakur added 4 commits July 28, 2026 20:52

feat(db): add dateCreated and lastModified to Repo

bc1591f

Populate dates on create and bump lastModified on user-role mutations. Backfill missing fields on NeDB/Mongo startup so Date Created/Modified sorting in the repo list works for existing records. Fixes finos#1486.

fix(db): drop startup backfill per review (finos#1656)

a22752d

Remove backfillRepoDates and startup hooks; existing-repo migration will follow in a separate PR with a versioned migration framework.

test(db): cover removeUserCanAuthorise lastModified bump

b721cdb

NeDB adaptor already bumps lastModified on all user-role mutations; extend finos#1486 date-field tests to assert removeUserCanAuthorise preserves dateCreated while advancing lastModified.

docs(db): note deferred Repo date backfill migration

fa86d42

Record that existing-record backfill stays out of startup and belongs in a follow-up versioned migration using Mongo $toDate on _id.

sankalpsthakur force-pushed the prep/1486-repo-date-fields branch from 78f78ea to fa86d42 Compare July 28, 2026 15:23

github-actions Bot added the feature label Jul 28, 2026

andypols mentioned this pull request Jul 28, 2026

feat: DB Migrations #1661

Open

Uh oh!

Conversation

sankalpsthakur commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Scope / issue linkage

Test plan

AI/LLM disclosure

Uh oh!

netlify Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Uh oh!

andypols left a comment

Choose a reason for hiding this comment

Uh oh!

linux-foundation-easycla Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sankalpsthakur commented Jul 22, 2026

Uh oh!

sankalpsthakur commented Jul 22, 2026

Uh oh!

codecov Bot commented Jul 23, 2026

Codecov Report

Uh oh!

sankalpsthakur commented Jul 23, 2026

Uh oh!

sankalpsthakur commented Jul 27, 2026

Uh oh!

sankalpsthakur commented Jul 28, 2026

Uh oh!

sankalpsthakur commented Jul 28, 2026

Uh oh!

andypols commented Jul 28, 2026

Uh oh!

sankalpsthakur commented Jul 28, 2026

Uh oh!

sankalpsthakur commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sankalpsthakur commented Jul 22, 2026 •

edited

Loading

netlify Bot commented Jul 22, 2026 •

edited

Loading

linux-foundation-easycla Bot commented Jul 22, 2026 •

edited

Loading